Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type hint annotations to
plasmapy.particles
#2458Improve type hint annotations to
plasmapy.particles
#2458Changes from 17 commits
aac87c9
28707c9
427b86c
68e2540
3618dce
ba86937
f1a52a2
b62e7cf
725e8a1
2deee44
6bbe7b1
dbbd44c
a35f6f3
d2f2b07
d61c676
d76361c
5a9cb90
2ea880c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about creating a type alias variable for all of this since it gets repeated, but if we make
_physical_particle_factory
into a public function, the type alias variable would need to also be public so that the documentation build doesn't break...I think.