Make common_isotopes, known_isotopes, and stable_isotopes each return a ParticleList
#2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plasmapy.particles
github-actions
bot
added
testing
changes existing API
namurphy
commented
Mar 5, 2024
| @@ -664,11 +664,11 @@ def common_isotopes_for_element( | |||
| CommonIsotopes = [ | |||
| isotope | |||
| for isotope in isotopes | |||
| if "abundance" in _isotopes.data_about_isotopes[isotope] | |||
| if "abundance" in _isotopes.data_about_isotopes[isotope.isotope] | |||
There was a problem hiding this comment.
Particle.isotope returns a string with the symbol of the isotope, which is expected by that dict.
There was a problem hiding this comment.
I thought we didn't return dict objects?
There was a problem hiding this comment.
The dict here was a private one containing isotope data, so it wasn't part of our public API. I'd say that there are times when a dict is a good choice for a return value, and other times when it's worth creating something like a class or namedtuple. As with everything, there are tradeoffs!
namurphy
commented
Mar 5, 2024
namurphy
commented
Mar 5, 2024
Comment on lines
-486
to
-488
| isotopic_abundance_elements = ( | ||
| atomic_number(atomic_numb) for atomic_numb in range(1, 119) | ||
| ) |
There was a problem hiding this comment.
I seem to have discovered Python generators in Dec 2017 and perhaps maybe had just a little bit too much fun with them...
namurphy
commented
Mar 5, 2024
namurphy
changed the title
common_isotopes, known_isotopes, and stable_isotopes return a ParticleListcommon_isotopes, known_isotopes, and stable_isotopes each return a ParticleList
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
github-actions
bot
removed
the
status: ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on #2458, I noticed that a few of the functions in
plasmapy.particles.atomiceach returned alistcontainingParticleobjects. This PR changes it so that they return aParticleList.