Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The elements of the Content felt behind the elements of host website with high z-index #157

Merged
merged 4 commits into from
Aug 27, 2022
Merged

Conversation

neotan
Copy link
Contributor

@neotan neotan commented Aug 27, 2022

Details

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current PR for duplication.

@neotan neotan closed this Aug 27, 2022
@louisgv louisgv reopened this Aug 27, 2022
@louisgv louisgv self-requested a review August 27, 2022 21:25
Signed-off-by: L <6723574+louisgv@users.noreply.github.com>
Signed-off-by: L <6723574+louisgv@users.noreply.github.com>
@louisgv
Copy link
Contributor

louisgv commented Aug 27, 2022

Tho let's not use important, as we do want to allow developer to override it as needed.

Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit 71c95bc into PlasmoHQ:main Aug 27, 2022
@neotan neotan deleted the fix/z-index-issue branch August 28, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The elements of the Content felt behind the element of host website with high z-index
2 participants