Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement isLoading state #56

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: implement isLoading state #56

merged 2 commits into from
Jun 18, 2024

Conversation

nvitaterna
Copy link
Contributor

Fixes #55

louisgv
louisgv approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice unit test 👍 - will cleanup

@louisgv louisgv merged commit e22a8c6 into PlasmoHQ:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No loading state available
2 participants
@nvitaterna @louisgv