Skip to content

Commit

Permalink
Fix visual diff failing to getfile if there is a space in the path
Browse files Browse the repository at this point in the history
Fix missing double quotes around the RevSpec in PlasticSourceControlUtils::RunGetFile()

Bug introduced by PR #77 1003295-fix-getfile-perf-using-shell in commit 33e4af1 by Sébastien Rombauts, 2023/04/06:
    Fix performance issue with the diff of assets

    Rename RunDumpToFile() to RunGetFile()
    Remove its first parameter InPathToPlasticBinary
    Make it call "getfile" on the background shell instead of executing a new dedicated cm process

In the refactor I dropped by mistake the double quotes that surrounded the RevSpec in:
	FString FullCommand = TEXT("cat \"");
	FullCommand += InRevSpec;
	FullCommand += TEXT("\" --raw --file=\"");
  • Loading branch information
SRombautsU committed Jul 13, 2023
1 parent a7a5cf5 commit 5775563
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ bool RunGetFile(const FString& InRevSpec, const FString& InDumpFileName)
FString Errors;

TArray<FString> Parameters;
Parameters.Add(InRevSpec);
Parameters.Add(FString::Printf(TEXT("\"%s\""), *InRevSpec));
Parameters.Add(TEXT("--raw"));
Parameters.Add(FString::Printf(TEXT("--file=\"%s\""), *InDumpFileName));
const bool bResult = PlasticSourceControlUtils::RunCommand(TEXT("getfile"), Parameters, TArray<FString>(), Results, Errors);
Expand Down

0 comments on commit 5775563

Please sign in to comment.