Fix performance issue with the diff of assets #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename RunDumpToFile() to RunGetFile() Remove its first parameter InPathToPlasticBinary Make it call "getfile" on the background shell instead of executing a new dedicated cm process
SRombautsU
force-pushed
the
1003295-fix-getfile-perf-using-shell
branch
from
f1e6e0d
to
33e4af1
Compare
juliomaqueda
approved these changes
Apr 13, 2023
SRombautsU
added a commit
that referenced
this pull request
Jul 13, 2023
Fix missing double quotes around the RevSpec in PlasticSourceControlUtils::RunGetFile() Bug introduced by PR #77 1003295-fix-getfile-perf-using-shell in commit 33e4af1 by Sébastien Rombauts, 2023/04/06: Fix performance issue with the diff of assets Rename RunDumpToFile() to RunGetFile() Remove its first parameter InPathToPlasticBinary Make it call "getfile" on the background shell instead of executing a new dedicated cm process In the refactor I dropped by mistake the double quotes that surrounded the RevSpec in: FString FullCommand = TEXT("cat \""); FullCommand += InRevSpec; FullCommand += TEXT("\" --raw --file=\"");
SRombautsU
added a commit
that referenced
this pull request
Jul 13, 2023
Fix SRombauts#130 Diff against Depot doesn't work if the path contains a space (regression in 1.8.1) Fix missing double quotes around the RevSpec in PlasticSourceControlUtils::RunGetFile() Bug introduced by PR #77 1003295-fix-getfile-perf-using-shell in commit 33e4af1 by Sébastien Rombauts, 2023/04/06: Fix performance issue with the diff of assets Rename RunDumpToFile() to RunGetFile() Remove its first parameter InPathToPlasticBinary Make it call "getfile" on the background shell instead of executing a new dedicated cm process In the refactor I dropped by mistake the double quotes that surrounded the RevSpec in: FString FullCommand = TEXT("cat \""); FullCommand += InRevSpec; FullCommand += TEXT("\" --raw --file=\"");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename RunDumpToFile() to RunGetFile()
Remove its first parameter InPathToPlasticBinary
Make it call "getfile" on the background shell instead of executing a new dedicated cm process