Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for check in a tree of multiple private files and folders from the View Changes window in version 1.10.0 #113

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

SRombautsU
Copy link

In version 1.10.0 the View Changes can show the local changes and private files in the Default changelist. It is possible to check in the changelist, but this will succeed only if there is a single new file in a private folder; it fails if the private folder contains multiple new files:
LogSourceControl: ExecuteSynchronousCommand: CheckIn LogSourceControl: Warning: RunCommand: 'checkin --commentsfile="C:/UnitySrc/UE53Plastic1100/Saved/Logs/Temp-702585FD4A268D2338CEB6BBD2B82A69.txt" --all --private --dependencies "c:/UnitySrc/UE53Plastic1100/Plugins/UEPlasticPlugin/PlasticSourceControl.uplugin" "c:/UnitySrc/UE53Plastic1100/Plugins' (in 0.292s) output (72 chars): Error: An item with the same key has already been added. Key: /Plugins

The issue needs to be worked around like for Perforce, by explicitly adding those files to source control before checking them in

@SRombautsU SRombautsU added the bug label Apr 3, 2024
@SRombautsU SRombautsU self-assigned this Apr 3, 2024
@SRombautsU SRombautsU marked this pull request as draft April 3, 2024 07:34
@SRombautsU
Copy link
Author

This PR is a Draft, pending another bug fix blocking it!

@SRombautsU SRombautsU force-pushed the 1005138-checkin-private-files-and-folders branch from 0062391 to 7f43160 Compare April 4, 2024 09:56
@SRombautsU SRombautsU marked this pull request as ready for review April 4, 2024 09:59
@juliomaqueda juliomaqueda merged commit 24eadf7 into master Apr 5, 2024
@juliomaqueda juliomaqueda deleted the 1005138-checkin-private-files-and-folders branch April 5, 2024 10:27
@SRombautsU SRombautsU added this to the 1.10.1 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants