Fix changelist files status of files outside content folder #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output This should be much faster then going through our custom cm shell parser, it remove some verbose logs and help inspect the output during development update ParseChangelistsResults() accordingly
…RootDirs" (other than Content, Config, Plugins, Source and Engine/Content) The issue was trying to fill in a "map" of files grouped by Path with a variable that was "moved" using MoveTemp() so the path was cleared and the corresponding was Empty when the item was added to the map!
…update FPlasticGetPendingChangelistsWorker to make use of these status info
juliomaqueda
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: trying to checking a whole tree of private files and folders through the View Changes, see related PR #113 Fix for check in a tree of multiple private files and folders from the View Changes window in version 1.10.0