Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on updating workspace using "Sync" from global source control menu #46

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Fix crash on updating workspace using "Sync" from global source control menu #46

merged 6 commits into from
Nov 8, 2022

Commits on Oct 28, 2022

  1. Remove the InConcurrency unused arguments from all commands 

    It was used in the past for handling logs differently, but it was adding complexity for no good reason
    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0e6d3e7 View commit details
    Browse the repository at this point in the history

  2. Apply a potential crash fix for Garbage Collection on Package Reloads… 

    … (it doesn't fix our crash though)

From AssetViewUtils::SyncPathsFromSourceControl():
Note: we will store the package using weak pointers here otherwise we might have garbage collection issues after the ReloadPackages call
    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    43dfb76 View commit details
    Browse the repository at this point in the history

  3. Add a "SyncAll" custom operation to hold the list of UpdatedFiles 

    Actually shared the same Worker & code
    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    06f9745 View commit details
    Browse the repository at this point in the history

  4. Move code to a new PlasticSourceControlUtils::RunSync() and implement… 

    … ParseSyncResults()
    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    2093974 View commit details
    Browse the repository at this point in the history

  5. Use the list of updated files to reload only what is needed

    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    1c1349b View commit details
    Browse the repository at this point in the history

  6. Re-enable the "Sync/Update" action of the source control menu

    @SRombautsU
    SRombautsU committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f70895b View commit details
    Browse the repository at this point in the history