Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on updating workspace using "Sync" from global source control menu #46

Merged
merged 6 commits into from Nov 8, 2022
Merged

Fix crash on updating workspace using "Sync" from global source control menu #46

merged 6 commits into from Nov 8, 2022

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Oct 28, 2022 •
edited

Changes:

  • Remove the InConcurrency unused arguments from all commands (no effect)
  • Apply a potential crash fix for Garbage Collection on Package (from UE5.1 source code, but doesn't help in our case, investigation pending)
  • Add a "SyncAll" custom operation to hold the list of UpdatedFiles
  • Move the code fo the "sync" operation to a new PlasticSourceControlUtils::RunSync() and implement ParseSyncResults()
  • Use the list of updated files to reload only packages that are needed
  • Re-enable the "Sync/Update" action of the source control menu now that it is no more crashing

@SRombautsU
Remove the InConcurrency unused arguments from all commands
0e6d3e7 
It was used in the past for handling logs differently, but it was adding complexity for no good reason
@SRombautsU
Apply a potential crash fix for Garbage Collection on Package Reloads…
43dfb76 
… (it doesn't fix our crash though)

From AssetViewUtils::SyncPathsFromSourceControl():
Note: we will store the package using weak pointers here otherwise we might have garbage collection issues after the ReloadPackages call
@SRombautsU
Add a "SyncAll" custom operation to hold the list of UpdatedFiles
06f9745 
Actually shared the same Worker & code
@SRombautsU SRombautsU self-assigned this Oct 28, 2022
@SRombautsU SRombautsU force-pushed the 1001351-fix-crash-on-sync-workspace branch from c92dd45 to f70895b Compare October 28, 2022 15:47
@SRombautsU SRombautsU changed the title [WIP] Fix crash on updating workspace using "Sync" from global source control menu Fix crash on updating workspace using "Sync" from global source control menu Oct 28, 2022
@juliomaqueda juliomaqueda merged commit 96a98ce into master Nov 8, 2022
@juliomaqueda juliomaqueda deleted the 1001351-fix-crash-on-sync-workspace branch November 8, 2022 15:54
@SRombauts SRombauts mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliomaqueda juliomaqueda juliomaqueda approved these changes

Assignees

@SRombautsU SRombautsU

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SRombautsU @juliomaqueda