Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspace also reload the current map if needed #47

Merged
merged 11 commits into from
Nov 22, 2022

Commits on Nov 18, 2022

  1. Fix "update" should not take a path in regular workspace

    First, update will not use it and act on the whole workspace instead
    Second, it fails if provided multiple file paths (which is the case when called from a new UE5.1 UI to Sync the whole workspace)
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0310346 View commit details
    Browse the repository at this point in the history
  2. Fix RunSync() to use --xml only for regular workspace

    The previous task 1001351 was only about the "SyncAll" for a regular workspace
    but the implementation introduced a regression since it was also used on partial workspace, while "cm partial update" doesn't accept --xml
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    45c31f1 View commit details
    Browse the repository at this point in the history
  3. Add a default constructor to FScopedTempFile that only hold the temp …

    …filename
    
    Doesn't create a file not write text to it
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c25e100 View commit details
    Browse the repository at this point in the history
  4. Fix RunSync() using a FScopedTempFile to delete the temp file after use

    Else it was cluttering the Saved/Logs folder with Plastic-Temp files
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    84e178a View commit details
    Browse the repository at this point in the history
  5. Implement a GetCurrentWorld() to get the World currently loaded in Ed…

    …itor
    
    In order to access the corresponding umap asset package to be reloaded at the end of the workspace update
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4b06833 View commit details
    Browse the repository at this point in the history
  6. Detects if some packages to reload are referencing the current map

    in which case the current map need to be reloaded, so it needs to be added to the list of packages if not already in
    
    (assets that are parts of a map in the new One File Per Actor (OFPA) in UE5 are __ExternalActors__ or __ExternalObjects__)
    SRombautsU committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7d766d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Configuration menu
    Copy the full SHA
    24311ee View commit details
    Browse the repository at this point in the history
  2. Rework how the code deal with removing the "/Game" prefix on asset pa…

    …th to avoid the use of a magic value
    SRombautsU committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    afedea7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    754b6e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Configuration menu
    Copy the full SHA
    f70b3cf View commit details
    Browse the repository at this point in the history
  2. Fix issue in case of the update only bring files that are Added

    In this case, these assets were not loaded before the operation so they are not yet in memory, so we can not search for them in the list of Packages!
    We have to do the search on the list of files updated by source control, that is, on strings containing absolute file paths instead of internal unreal relative path /Game
    SRombautsU committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    086dde0 View commit details
    Browse the repository at this point in the history