Update workspace also reload the current map if needed #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, update will not use it and act on the whole workspace instead Second, it fails if provided multiple file paths (which is the case when called from a new UE5.1 UI to Sync the whole workspace)
The previous task 1001351 was only about the "SyncAll" for a regular workspace but the implementation introduced a regression since it was also used on partial workspace, while "cm partial update" doesn't accept --xml
…filename Doesn't create a file not write text to it
Else it was cluttering the Saved/Logs folder with Plastic-Temp files
…itor In order to access the corresponding umap asset package to be reloaded at the end of the workspace update
in which case the current map need to be reloaded, so it needs to be added to the list of packages if not already in (assets that are parts of a map in the new One File Per Actor (OFPA) in UE5 are __ExternalActors__ or __ExternalObjects__)
SRombautsU
force-pushed
the
1002363-update-workspace-reload-map
branch
from
461214b
to
7d766d1
Compare
juliomaqueda
requested changes
Nov 21, 2022
There was a problem hiding this comment.
Great work, @SRombautsU! Please, checkout the review comments.
Source/PlasticSourceControl/Private/PlasticSourceControlUtils.cpp
Outdated
Show resolved
Hide resolved
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
…th to avoid the use of a magic value
juliomaqueda
approved these changes
Nov 21, 2022
SRombautsU
force-pushed
the
1002363-update-workspace-reload-map
branch
2 times, most recently
from
e0421b2
to
d1e8466
Compare
In this case, these assets were not loaded before the operation so they are not yet in memory, so we can not search for them in the list of Packages! We have to do the search on the list of files updated by source control, that is, on strings containing absolute file paths instead of internal unreal relative path /Game
SRombautsU
force-pushed
the
1002363-update-workspace-reload-map
branch
from
d1e8466
to
086dde0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects if some packages to reload are OFPA from the the current map
in which case the current map need to be reloaded, so it needs to be added to the list of packages if not already in