User connected to a cloud server can open the Dashboard #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les in Unity's Dashboard if the workspace points to a cloud organization
SRombautsU
requested changes
Sep 19, 2023
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
#90 - Remove not needed Plugin initialization - Adapt function argument to Unreal's convention - Unify string.Find - Remove icon fallback as it is present in UE4.27
To get rid of 3 FString to FText to FString conversions
SRombautsU
approved these changes
Sep 19, 2023
|
LGTM, validation is now completed. Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new button to the global revision control menu to open Lock Rules in Unity's Dashboard if the workspace points to a cloud organization
How