Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] NEW: Persian/Farsi (fa_IR) #218

Merged
merged 3 commits into from Aug 20, 2022
Merged

[Localization] NEW: Persian/Farsi (fa_IR) #218

merged 3 commits into from Aug 20, 2022

Conversation

amirsaam
Copy link
Member

@amirsaam amirsaam commented Aug 20, 2022

I think it would need some UI tweaks because of Persian/Farsi being a RTL language.

@IsaacMarovitz
Copy link
Member

RTL languages will be supported in >2.0.0 but are currently untested in 1.1.1

@IsaacMarovitz IsaacMarovitz added the localization Fixes or updates localizations label Aug 20, 2022
@amirsaam
Copy link
Member Author

Does it need further works from my side or it's ok for now until later?

@IsaacMarovitz
Copy link
Member

I'm testing in 1.1.1 now, will upload screenshots in a sec

@IsaacMarovitz
Copy link
Member

IsaacMarovitz commented Aug 20, 2022

Screenshot 2022-08-20 at 19 02 53

Screenshot 2022-08-20 at 19 03 11

Screenshot 2022-08-20 at 19 03 23

Looks mostly good. Let me know if you see any issues

@IsaacMarovitz
Copy link
Member

Screenshot 2022-08-20 at 19 04 33

@amirsaam
Copy link
Member Author

It's looking good to me.
Only on "Experiencing an issue?" page looks like the texts are not wrapped.
On the step 7, you can tell the texts are not showing and instead go to next line they became "..."

And I need to change one translation.

@amirsaam
Copy link
Member Author

And I didn't know PlayCover is on Hosted Weblate ready for translate 💀

@Depal1 Depal1 merged commit ef93592 into PlayCover:develop Aug 20, 2022
@Candygoblen123
Copy link
Member

And I didn't know PlayCover is on Hosted Weblate ready for translate 💀

yeah it was just create, there was no way for you to have known.

@amirsaam amirsaam deleted the fa-IR-localization branch August 20, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Fixes or updates localizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants