Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding invalid state transition test + unit test #133

Merged
merged 2 commits into from Aug 2, 2022

Conversation

dgkanatsios
Copy link
Contributor

This PR introduces a check for invalid state transitions between two subsequent heartbeat requests as well as a corresponding unit test. A couple of points

  • the check for invalid state transition currently only checks for transition from StandingBy to Initializing. We expect to expand with more checks in the future
  • we want to kill LocalMultiplayerAgent when an invalid transition happens. This is to facilitate running LMA in a CI/CD environment
  • the way that we kill the LMA process is by using the IHostApplicationLifeTime object. We've used this way in a Thundernetes sample and has worked great so far. Not sure if there is a better way.

@dgkanatsios dgkanatsios added enhancement New feature or request tests labels Aug 1, 2022
@dgkanatsios dgkanatsios requested a review from a team August 1, 2022 10:09
@dgkanatsios dgkanatsios force-pushed the invalidstatetransition branch 3 times, most recently from 9a9a4ce to 28b34dc Compare August 1, 2022 10:21
@dgkanatsios dgkanatsios merged commit d48c9e5 into main Aug 2, 2022
@dgkanatsios dgkanatsios deleted the invalidstatetransition branch August 2, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants