Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed TransitionToActiveEvent #111

Merged
merged 8 commits into from
Jan 2, 2022
Merged

Conversation

nassosterz-ms
Copy link
Contributor

@nassosterz-ms nassosterz-ms commented Dec 20, 2021

What this PR does / why we need it:

  • Solves the locked main thread issue when server is on Standby.
  • Replace TransitionToActiveEvent object with 2 new Delegates: OnServerActive and OnGameServerInitializationComplete
  • OnGameServerInitializationComplete allows user to add custom code when game server transitions from Initialization to
    StandBy
  • OnServerActive allows user to add custom code when game server transitions from StandBy to Active

Special notes for your reviewer:

  • Has been tested with UE 4.27.1 and UE5 early access

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UGSDKReadyForPlayersAction also needs to be adapted to work with the delegates.

UnrealPlugin/Source/PlayfabGSDK/Public/GSDKInternal.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKInternal.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKUtils.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKUtils.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/PlayfabGSDK.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKUtils.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/PlayfabGSDK.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/PlayfabGSDK.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKUtils.h Outdated Show resolved Hide resolved
UnrealPlugin/Source/PlayfabGSDK/Public/GSDKUtils.h Outdated Show resolved Hide resolved
@nassosterz-ms nassosterz-ms merged commit f6ced2b into master Jan 2, 2022
@nassosterz-ms nassosterz-ms deleted the nt/refactor-transition-event branch January 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants