Update ConnectedPlayer.h #141
Conversation
PlayerId is exposed to the Blueprint due to creating an array struct for the "Update Connected Players" function.
|
This is with main. I am able to make (and also tried breaking) the ConnectedPlayer struct. I understand you want to be able to set player id also when you make the struct, so changing BlueprintReadOnly to BlueprintReadWrite seems reasonable, the other changes dont seem to be needed. |
|
|
| USTRUCT(BlueprintType) | ||
| struct FConnectedPlayer | ||
| { | ||
| GENERATED_BODY() | ||
| public: | ||
| UPROPERTY(BlueprintReadOnly) | ||
| UPROPERTY(EditAnywhere, BlueprintReadWrite) |
There was a problem hiding this comment.
I agree with the change BlueprintReadOnly -> BlueprintReadWrite.
Any reason you are suggesting the EditAnywhere change?
There was a problem hiding this comment.
I just wanted to have accessibility both on C++ and Blueprint Graph.
There was a problem hiding this comment.
The EditAnywhere property isnt related to C++ afaik. In C++ you can access FStringId easily since FConnectedPlayer is a struct
|
Closing this PR since there are conflicts, will re open a new one with the changes that have been suggested. Please feel free to review it! |
PlayerId is exposed to the Blueprint due to creating an array struct for the "Update Connected Players" function.