Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration with AzureMonitor]: Adding changes to send metrics for Standingby servers to AppInsights. #405

Closed
wants to merge 3 commits into from

Conversation

rangira
Copy link

@rangira rangira commented Sep 21, 2022

The PR addresses the issue #383

@ghost
Copy link

ghost commented Sep 21, 2022

CLA assistant check
All CLA requirements met.

@dgkanatsios
Copy link
Collaborator

hey @rangira, thanks for the PR! Ideally, we would not want to have product specific code inside Thundernetes. Any chance we can have Azure Monitor grab the already existing Prometheus metrics? If this is not possible, we can always have an external component on the ThundernetesContrib repository: https://github.com/PlayFab/thundernetescontrib

Thanks again for the contribution and apologies for the inconvenience!

@dgkanatsios
Copy link
Collaborator

@rangira
Copy link
Author

rangira commented Sep 21, 2022

@dgkanatsios Thank you for sharing that. Could you please help me understand what are referring to when you say "product specific code". Are you referring to azure sdk for appinsights? Should it not be imported?
I can take a look at link

@dgkanatsios
Copy link
Collaborator

Yeah, the "AppInsights" code, exactly. At this point, we want to have these available as "extensions", hence the existence of the "ThundernetesContrib" repository as we want the Thundernetes core code base to be as lean as possible. Apologies again for the inconvenience and thanks for understanding, lets us know if you have any more questions!

@dgkanatsios
Copy link
Collaborator

ping @rangira, any help needed? Appreciate all the hard work!

@dgkanatsios
Copy link
Collaborator

Closing because of inactivity, feel free to reopen if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants