Make Plume compile on release #365
Conversation
Create SignedJson and implement FromData for it
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 28.2% 28.73% +0.53%
==========================================
Files 62 62
Lines 6578 5658 -920
==========================================
- Hits 1855 1626 -229
+ Misses 4723 4032 -691 |
| pub fn verify_header(&self, other: &Digest) -> bool { | ||
| self.value()==other.value() | ||
| } | ||
|
|
||
| pub fn algorithm(&self) -> &str { |
There was a problem hiding this comment.
i just realised we have a lot of public functions here, but don't document any
There was a problem hiding this comment.
Yes, we should do it. Also we should probably use https://git.asonix.dog/asonix/http-signatures instead of rolling our own code
|
we should also expand our .travis.yml to (test) build |
|
Maybe we should just test in release, that's what peoples will use anyway |
trinity-1686a
added
S: Ready for review
|
except for us developers, so, yeah, 👍 |
|
I should also update install instructions |
|
Oops I broke code coverage even more I think |
|
Just posting this here, as it might be relevant for this pull request: |
|
@marek-lach Thanks! It is indeed related. I responded them. |
Remove use of String for body parameters
Create SignedJson and implement FromData for it
Fix #328