Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - initial RTL support #575 #577

Merged
merged 9 commits into from Jul 11, 2019
Merged

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented May 13, 2019

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including:

  • BIDI to be applied to form fields (which are rendered dynamically)
  • fix css styles and remove text-align, modify margin/madding left/right
  • BIDI to be applied to every elements inside article for post content

@ahangarha ahangarha changed the title #575 WIP - initial RTL support WIP - initial RTL support #575 May 13, 2019
@trinity-1686a
Copy link
Contributor

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #577 into master will decrease coverage by 0.76%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   35.28%   34.51%   -0.77%     
==========================================
  Files          68       67       -1     
  Lines        7899     7872      -27     
  Branches     1891     1890       -1     
==========================================
- Hits         2787     2717      -70     
- Misses       4334     4394      +60     
+ Partials      778      761      -17

@ahangarha
Copy link
Contributor Author

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

@elegaanz
Copy link
Member

No it was not your fault, CI fails for no good reasons sometimes. I restarted the failed job, let's hope it will work this time.

@trinity-1686a
Copy link
Contributor

  • BIDI to be applied to form fields (which are rendered dynamically)
  • fix css styles and remove text-align, modify margin/madding left/right
  • BIDI to be applied to every elements inside article for post content

I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

@ahangarha
Copy link
Contributor Author

It you don't mind, merge it. I will send another PR for the following improvements.

@trinity-1686a trinity-1686a added A: I18N Translations, and related code C: Enhancement New feature or request S: Ready for review This PR is ready to be reviewed labels Jul 10, 2019
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igalic igalic merged commit 54c6d21 into Plume-org:master Jul 11, 2019
@ahangarha ahangarha deleted the add-rtl-support branch July 29, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: I18N Translations, and related code C: Enhancement New feature or request S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants