New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - initial RTL support #575 #577
Conversation
if you want to tinker that, forms are rendered using what's in |
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 35.28% 34.51% -0.77%
==========================================
Files 68 67 -1
Lines 7899 7872 -27
Branches 1891 1890 -1
==========================================
- Hits 2787 2717 -70
- Misses 4334 4394 +60
+ Partials 778 761 -17 |
0d63081
to
97927fe
Compare
this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes? |
No it was not your fault, CI fails for no good reasons sometimes. I restarted the failed job, let's hope it will work this time. |
some parts should be recheck carefully in real usage
I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr? |
It you don't mind, merge it. I will send another PR for the following improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including: