cargo release helper #790
cargo release helper #790
Conversation
and also add overrides in all other crates, since we only have one CHANGELOG.md: crate-ci/cargo-release#205 we might wanna have that looked at or fixed
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 39.09% 39.10% +0.01%
==========================================
Files 73 73
Lines 9756 9758 +2
Branches 2233 2233
==========================================
+ Hits 3814 3816 +2
- Misses 4885 4887 +2
+ Partials 1057 1055 -2 |
|
uh… will we need to add it as development dependency? |
release.toml
Outdated
| {file="CHANGELOG.md", search="\\.\\.\\.dev", replace="...{{tag_name}}", exactly=1}, | ||
| {file="CHANGELOG.md", search="ReleaseDate", replace="{{date}}"}, | ||
| {file="CHANGELOG.md", search="<!-- next-header -->", replace="<!-- next-header -->\n\n## [Unreleased] - ReleaseDate", exactly=1}, | ||
| {file="CHANGELOG.md", search="<!-- next-url -->", replace="<!-- next-url -->\n[Unreleased]: https://github.com/assert-rs/predicates-rs/compare/{{tag_name}}...HEAD", exactly=1}, |
There was a problem hiding this comment.
Shouldn't the repo URL be changed here?
There was a problem hiding this comment.
To something like https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD, so that the changelog links to our commit history.
There was a problem hiding this comment.
Also, is there a <!-- next-url --> somewhere in the changelog you added? I can't find it.
There was a problem hiding this comment.
i didn't add it to our current changelog
|
Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent. And for the development dependency, I don't think so. It should be documented here that people who want to publish a new release should use this tool tho. |
|
n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page for the future of the changelog, i absolutely agree |
|
I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable). |
|
Also, could it be possible to add |
the only problem was time and energy
that's a very good idea! how do i make it work? ◆ plume git:(fix/cargo-release-helper) ❯❯❯ crowdin pull
Project key is empty
✖ 1 plume git:(fix/cargo-release-helper) ❯❯❯ |
|
I don't remember how the Crowdin CLI works, I'll check that and edit the PR. I'll also edit the changelog. |
|
So the translations should be pulled now, if you have a |
let's create a doc issue right now, and link it here |
|
what about docker? |
|
I think the release should be automatic, I'll check. |
|
It is not, I'll a hook. |
|
The thing is, the docker tag needs to be pushed after the git tag, and there is no So maybe we can document that this has to be done manually, and do it by hand for the moment? |
|
or we could add docker tag to the CI build process, only on tag |
|
yunohost relies on docker, right? |
|
It doesn't, it uses Bash scripts. I'm not sure if it is better tho… 😅 |
as discussed here: https://github.com/igalic/Plume/pull/1
|
we should open a pr or issue to release a new version on Yunohost after the release? |
|
That's good! |
how to use?