PrimePY: using array slicing #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to use array slicing and numpy. Increases perf by 20x Signed-off-by: Janne Kotka <lekonna@gmail.com>
|
I have also one without numpy. keep the initialization as in the original and replace the for loop with |
|
I think that we can consider slicing faithful, but I am open to discussion. |
|
IMO, it might be a good idea to have separate python and python_numpy implementations. |
|
I would agree that slicing is faithful. However, we can't merge this PR until it is opened on the drag-race branch. |
This was referenced Jun 25, 2021
Closed
|
Closing due to lack of contributor response. Can be reopened on drag-race branch if desired. |
1 similar comment
|
Closing due to lack of contributor response. Can be reopened on drag-race branch if desired. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use array slicing and numpy. Increases perf
by 20x
Signed-off-by: Janne Kotka lekonna@gmail.com