Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add functionality to Demag GUI for averaging multiple measurements #328

Closed
lfairchild opened this issue Apr 11, 2018 · 3 comments
Closed

add functionality to Demag GUI for averaging multiple measurements #328

lfairchild opened this issue Apr 11, 2018 · 3 comments
Labels
New Feature

Comments

@lfairchild
Copy link
Contributor

Currently, the only option for averaging multiple measurements at the same treatment step appears during the initial conversion of magnetometer files to MagIC format. Even then, the conversion scripts are pretty inflexible as they require you to make the choice between importing everything and averaging for all replicate measurements in the dataset.

It would be great if Demag GUI provided the option to selectively average "good" replicate measurements for each sample in addition to the "bad measurement" flags already available. It seems that implementing this in the GUI could be tricky though. @Caoimhinmg what do you think?
@Caoimhinmg
Copy link
Collaborator

@lfairchild this would not be a trivial thing...Demag GUI is very much set up so that modifying the measurements file is not done beyond writing a b or g in quality. I'd either need to hack this in with a custom session file keeping track of what to average (of course then this wouldn't get published in MagIC) which I'm reluctant to do. Alternatively something would need to be added to the vocabulary to indicate to Demag GUI that 2 measurements should be averaged, unless we want to remove lines from the measurements file which is less than ideal as you cannot unaverage a measurement if the user changes their mind. @njarboe, @rminnett what do you think about the vocabulary thing? This might be a good addition as it could modify how the current importing scripts are handling averages which is by only reporting the average measurement, which involves a loss of information as explained above.

lfairchild added a commit to lfairchild/PmagPy that referenced this issue Nov 7, 2018
@lfairchild
exclude measurements marked 'bad' when averaging
48700dd 
Have pmag.vspec_magic[3] recognize quality flags and exclude bad
measurements when averaging repeat measurements at the same treatment
step. Progress toward PmagPy#328
lfairchild added a commit to lfairchild/PmagPy that referenced this issue Nov 7, 2018
@lfairchild
add basic averaging functionality to Demag GUI
b2be332 
Include built-in demag_gui function for bulk averaging multiple 'good'
measurements at the same treatment step. Currently, this action can only
be carried out for entire 'measurements.txt' files (not per individual
site or specimen). The averaging function is bound to a menu option and
issues a user_warning before averaging. Before measurements are
averaged, the original measurements file is written to a backup file
'all_measurements.txt'.

Refer to PmagPy#328
@moonshoes87
Copy link
Member

@lfairchild and @Caoimhinmg, let me know if I should leave this issue open, since it has not been touched in over a year.

@moonshoes87
Copy link
Member

I'm closing this issue. If someone wants to work on it, go ahead and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moonshoes87 @Caoimhinmg @lfairchild