This repository has been archived by the owner on Feb 9, 2019. It is now read-only.
Enforcing the fee structure #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick check to enforce the minimum fee for the amount of slots used in a block relative to the number of transactions. This check implies that if someone overpays for a slot, another tx could still have a lower fee while the block stays valid. This added block validation condition secures equal distribution of fees among blocks and miners. And this change makes fat block forging still possible when really needed. By sending a tx with a high fee.
…sactions. (And rejects fat blocks). Because that feature would still favors rich miners. Where the miner would use a privately held UT (not propagated) which is only self rewarding if a block is forged.
|
Added another option with a stricter fee verification, that doesn't allow paying for other transactions. (And rejects fat blocks). Because that feature would still favor rich miners. Where the miner would use a privately held UT (not propagated) which is only self rewarding if a block is forged. |
blankey1337
reviewed
Dec 17, 2018
blankey1337
reviewed
Dec 17, 2018
src/brs/BlockchainProcessorImpl.java
Outdated
| } | ||
|
|
||
| if (Burst.getFluxCapacitor().isActive(FeatureToggle.SLOT_FEE_ENFORCING) | ||
| && Constants.FEE_QUANT * ((block.getTransactions().size() / 2) * (1 + block.getTransactions().size())) > block.getTotalFeeNQT())) { |
There was a problem hiding this comment.
This probably deserves to be broken out into it's own function and properly unit tested.
blankey1337
reviewed
Dec 17, 2018
|
yes ofc. committed your suggestions. The unit test sounds like a good plan for the formula. Perhaps it needs to cast to a float for a proper division. |
|
This is a hard fork change and as such should be added to some other code fork of the BRS. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal for a quick check to enforce the minimum fee for the amount of slots used in a block relative to the number of transactions.
This check implies that if someone 'overpays' for a slot, another tx could still have a lower fee while the block stays valid. This added block validation condition improves fair distribution of fees among the blocks and miners.
Note that this change makes fat block forging still possible when really needed. By sending a tx with a high fee.