Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dev trade chat module #14

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

versedi
Copy link

@versedi versedi commented Jun 12, 2020

Bugs:

  • path backslashes

TODO:

  • Client.txt reader
  • Chat input handler to use for various modules
  • Notifications (see: wip insert link to road blocking issue)

@versedi versedi marked this pull request as draft June 12, 2020 01:30
private readonly snackbar: SnackBarService) {
}

public open(external: boolean): Observable<void> {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely to rewrite ctrl+c just so UI works

public run(feature: string, _: TradeUserSettings): void {
switch (feature) {
case 'chat-read-client-file':
this.chat.open(feature === 'chat-read-client-file').subscribe();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to trigger the read file service here

this.chat.open(feature === 'chat-read-client-file').subscribe();
break;
case 'chat-client-file-path':
this.chat.open(feature === 'chat-client-file-path').subscribe();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add validation if file exists, if it does start reading in file service

@@ -0,0 +1,3 @@
body {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove import or clear the file, unnecessary

};
}

public getFeatures(settings: TradeUserSettings): Feature[] {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add other features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant