Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ludicrous price estimation #107

Closed
SonOfDiablo opened this issue Dec 4, 2016 · 3 comments
Closed

Ludicrous price estimation #107

SonOfDiablo opened this issue Dec 4, 2016 · 3 comments

Comments

@SonOfDiablo
Copy link

So I just started in the Breach league and got a few uniques.
I wanted to see if they were worth anything and got this:
image

Something seems off on both of these estimations :/

I would love to get this fixed as fast as possible :)

@McHearty
Copy link

McHearty commented Dec 4, 2016

I too am having this issue

@Eruyome
Copy link
Collaborator

Eruyome commented Dec 4, 2016

The script is actually working as intended. While scraping poe.trade it reads the chaos equivalent from here:
error

data-value has the value we want and before this value was correct. Now it isn't. So there are 2 solutions:

  1. Wait until it's fixed on poe.trade but I have no idea how long this could take.
  2. Use the actual displayed value, determine the currency and find out try to use some median of the currency trades to get ratios and calculate the chaos equivalent with that.

I'd rather use solution 1, but we will have to see if that's agood idea.

@Eruyome
Copy link
Collaborator

Eruyome commented Dec 5, 2016

I've added a workaround, hope that works without problems. Reopen this if there seems to be anything wrong.

@Eruyome Eruyome closed this as completed Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants