Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do additional skill stat parsing in gem parsing instead of skill parsing #7

Merged
merged 12 commits into from
Mar 10, 2020
Merged

Do additional skill stat parsing in gem parsing instead of skill parsing #7

merged 12 commits into from
Mar 10, 2020

Commits on Mar 10, 2020

  1. Only disable secondary skill for vaal *auras*

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    21207d7 View commit details
    Browse the repository at this point in the history

  2. Add GemsParser to parse groups of gems

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    966a03a View commit details
    Browse the repository at this point in the history

  3. Add SkillIsEnabled meta stat; parse Gem.IsEnabled like Skill.IsEnabled 

    in Active/SupportSkillParser
    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3e039ce View commit details
    Browse the repository at this point in the history

  4. Add Skill.WithLevel/Quality/IsEnabled

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4e32561 View commit details
    Browse the repository at this point in the history

  5. Remove SkillModification

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    828ad67 View commit details
    Browse the repository at this point in the history

  6. Change AdditionalSkillQualityParser to use level stat instead of param

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    715a66c View commit details
    Browse the repository at this point in the history

  7. Remove ExplicitRegistrationType.ChangeInvalidatesSkillParse

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    c3f1c84 View commit details
    Browse the repository at this point in the history

  8. Rename SkillModificationParser to AdditionalSkillStatParser

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3596464 View commit details
    Browse the repository at this point in the history

  9. Call AdditionalSkillStatParser from GemsParser instead of SkillsParser

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4851618 View commit details
    Browse the repository at this point in the history

  10. Refactor AdditionalSkillLevel/QualityParser to implement IParser

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    aaeddee View commit details
    Browse the repository at this point in the history

  11. Only let enabled supports influence active skill level/quality

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    a7cb6d9 View commit details
    Browse the repository at this point in the history

  12. Add AdditionalSkillLevelMaximumParser

    @brather1ng
    brather1ng committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    41a3118 View commit details
    Browse the repository at this point in the history