Skip to content

Commit

Permalink
Change library projects to target .Net Standard and their tests to Core
Browse files Browse the repository at this point in the history
Had to resolve some minor incompatibilities. E.g. MoreLinq extension methods that are also part of System.Linq in .Net Standard 2.0
  • Loading branch information
brather1ng committed Jun 21, 2019
1 parent c9c0174 commit c944929
Show file tree
Hide file tree
Showing 23 changed files with 30 additions and 92 deletions.
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>PoESkillTree.Computation.Builders</RootNamespace>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Builders.Tests</AssemblyTitle>
<Product>PoESkillTree.Computation.Builders.Tests</Product>
Expand All @@ -11,7 +11,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -33,10 +33,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Builders\PoESkillTree.Computation.Builders.csproj" />
Expand Down
@@ -1,6 +1,5 @@
using System.Collections.Generic;
using System.Linq;
using MoreLinq;
using PoESkillTree.Computation.Common;

namespace PoESkillTree.Computation.Builders.Behaviors
Expand Down
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Builders</AssemblyTitle>
<Product>PoESkillTree.Computation.Builders</Product>
<Copyright>Copyright © 2018</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -19,9 +18,6 @@
<PackageReference Include="morelinq" Version="3.1.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Common\PoESkillTree.Computation.Common.csproj" />
Expand Down
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>PoESkillTree.Computation.Common</RootNamespace>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Common.Tests</AssemblyTitle>
<Product>PoESkillTree.Computation.Common.Tests</Product>
Expand All @@ -11,7 +11,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -32,9 +32,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.GameModel\PoESkillTree.GameModel.csproj" />
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
Expand Down
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Common</AssemblyTitle>
<Product>PoESkillTree.Computation.Common</Product>
<Copyright>Copyright © 2018</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -20,9 +19,6 @@
<PackageReference Include="morelinq" Version="3.1.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.GameModel\PoESkillTree.GameModel.csproj" />
Expand Down
@@ -1,15 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Console</AssemblyTitle>
<Product>PoESkillTree.Computation.Console</Product>
<Copyright>Copyright © 2017</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -24,9 +23,6 @@
<PackageReference Include="Newtonsoft.Json" Version="12.0.1" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Builders\PoESkillTree.Computation.Builders.csproj" />
Expand Down
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>PoESkillTree.Computation.Core</RootNamespace>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Core.Tests</AssemblyTitle>
<Product>PoESkillTree.Computation.Core.Tests</Product>
Expand All @@ -11,7 +11,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -32,9 +32,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.GameModel\PoESkillTree.GameModel.csproj" />
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
Expand Down
@@ -1,5 +1,4 @@
using System.Linq;
using MoreLinq;
using PoESkillTree.Computation.Common;

namespace PoESkillTree.Computation.Core.Nodes
Expand Down
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Core</AssemblyTitle>
<Product>PoESkillTree.Computation.Core</Product>
<Copyright>Copyright © 2017</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -21,9 +20,6 @@
<PackageReference Include="morelinq" Version="3.1.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Common\PoESkillTree.Computation.Common.csproj" />
Expand Down
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>PoESkillTree.Computation.Data</RootNamespace>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Data.Tests</AssemblyTitle>
<Product>PoESkillTree.Computation.Data.Tests</Product>
Expand All @@ -11,7 +11,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -32,9 +32,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Common\PoESkillTree.Computation.Common.csproj" />
Expand Down
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Data</AssemblyTitle>
<Product>PoESkillTree.Computation.Data</Product>
<Copyright>Copyright © 2017</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -20,9 +19,6 @@
<PackageReference Include="morelinq" Version="3.1.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Common\PoESkillTree.Computation.Common.csproj" />
Expand Down
5 changes: 3 additions & 2 deletions PoESkillTree.Computation.IntegrationTests/ParsingTestUtils.cs
Expand Up @@ -2,12 +2,13 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using MoreLinq;
using System.Reflection;
using NUnit.Framework;
using PoESkillTree.Computation.Common;
using PoESkillTree.Computation.Parsing;
using PoESkillTree.GameModel;
using PoESkillTree.GameModel.StatTranslation;
using static MoreLinq.Extensions.EquiZipExtension;

namespace PoESkillTree.Computation.IntegrationTests
{
Expand Down Expand Up @@ -81,7 +82,7 @@ public static IEnumerable<string> ReadNotParseableStatLines()
=> ReadDataLines("NotParseableStatLines").Concat(ReadDataLines("NotYetParseableStatLines"));

public static IEnumerable<string> ReadDataLines(string fileName)
=> File.ReadAllLines(TestContext.CurrentContext.TestDirectory + $"/Data/{fileName}.txt")
=> File.ReadAllLines(AppContext.BaseDirectory + $"/Data/{fileName}.txt")
.Where(s => !s.StartsWith("//", StringComparison.Ordinal))
.Distinct();

Expand Down
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.IntegrationTests</AssemblyTitle>
<Product>PoESkillTree.Computation.IntegrationTests</Product>
Expand All @@ -10,7 +10,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -33,9 +33,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
</ItemGroup>
Expand Down
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>PoESkillTree.Computation.Parsing</RootNamespace>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.2</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Parsing.Tests</AssemblyTitle>
<Product>PoESkillTree.Computation.Parsing.Tests</Product>
Expand All @@ -11,7 +11,7 @@
<NUnit3 Assemblies="$(OutputPath)/$(TargetFileName)" ToolPath="..\packages\NUnit.ConsoleRunner.3.7.0\tools\" />
</Target>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -33,9 +33,6 @@
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.2" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Computation.Builders\PoESkillTree.Computation.Builders.csproj" />
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
Expand Down
@@ -1,7 +1,6 @@
using System.Collections.Generic;
using System.Linq;
using Moq;
using MoreLinq;
using NUnit.Framework;
using PoESkillTree.Computation.Builders.Stats;
using PoESkillTree.Computation.Common;
Expand Down
2 changes: 1 addition & 1 deletion PoESkillTree.Computation.Parsing/CoreParser.cs
Expand Up @@ -30,7 +30,7 @@ namespace PoESkillTree.Computation.Parsing
public class CoreParser<TStep> : ICoreParser
{
private static readonly ILog Log =
LogManager.GetLogger($"{typeof(CoreParser<>).FullName}<{typeof(TStep).Name}>");
LogManager.GetLogger(typeof(CoreParser<>).Assembly, $"{typeof(CoreParser<>).FullName}<{typeof(TStep).Name}>");

private delegate StringParseResult<IReadOnlyList<Modifier>> Parser(CoreParserParameter parameter);

Expand Down
1 change: 0 additions & 1 deletion PoESkillTree.Computation.Parsing/Parser.cs
Expand Up @@ -3,7 +3,6 @@
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using MoreLinq;
using PoESkillTree.Computation.Common;
using PoESkillTree.Computation.Common.Builders;
using PoESkillTree.Computation.Common.Data;
Expand Down
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<AssemblyTitle>PoESkillTree.Computation.Parsing</AssemblyTitle>
<Product>PoESkillTree.Computation.Parsing</Product>
<Copyright>Copyright © 2017</Copyright>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Data.DataSetExtensions" Version="4.*" />
<PackageReference Include="Microsoft.CSharp" Version="4.*" />
<PackageReference Include="System.Net.Http" Version="4.*" />
</ItemGroup>
Expand All @@ -21,9 +20,6 @@
<PackageReference Include="morelinq" Version="3.1.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.ComponentModel.DataAnnotations" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PoESkillTree.Utils\PoESkillTree.Utils.csproj" />
<ProjectReference Include="..\PoESkillTree.Computation.Common\PoESkillTree.Computation.Common.csproj" />
Expand Down

0 comments on commit c944929

Please sign in to comment.