Replace IParser<TResult> by IStringParser<TResult> and move these to subnamespace.
The non-generic IParser interface will later be generalized to also support GivenStatsParser and parsers for items and skills, making this separation necessary. Plus this also allows grouping the now IStringParsers into a namespace.

Change previous IParser interface to ICoreParser.
Add new IParser<TResult> interface, implemented by ICoreParser using CoreParserParameter.
Usage of ICoreParser/CoreParser stayed the same, however the underlying interface can now be used for new parsers.

logging it and creating an appropriate ParseResult.
Add tests for CoreParser.

Refactor ParseResult for easier and safer usage

- With(Keyword) is now in IDamageRelatedStatBuilder instead of IStatBuilder and is used directly everywhere it needs to be.
- IConditionBuilders.With(Keyword) is no longer part specific, just MainSkillHasKeyword, and directly builds to a value condition. This the correct way everywhere it is still used because those mods refer to skills and are thus not affected by the skill part.
- Add IConditionBuilders.WithPart(Keyword) for those case where skill part specific keywords are required but the stat is not damage related,

that deserializes gem json into SkillDefinitions (far from complete atm).
Flesh out SkillDefinition a bit as required for the implemented deserialization parts.
Implement selection of Keywords from active skill types and gem tags.

to support everything relevant for Frenzy

Add gems.json and gem_tooltips.json to GameModel.Tests/Data containing 20 gems for easily testing fields that can't be tested with Frenzy as the one example skill alone.

- Ignore skills with unreleased base items
- Move ItemClass to GameModel project
- Deserialize active_skill.weapon_restrictions
- Deserialize per_level/static.crit_chance, .cooldown, .mana_multiplier and .mana_reservation_override
- Deserialize support_gem
- Set ActiveSkillDefinition.ProvidesBuff from active skill types

The integration test currently fails because there is no implementation.
Add SkillJsonDeserializer.DeserializeAsync() without parameters that uses the embedded resource files.

Just casting from/to double does not work with flags above 2^52. Casting to int in between stops working even earlier. (other enums don't have this problem because they are ints, which can be cast from/to double without loss)

(most is hardcoded for frenzy)
Add missing gem related stats (requirements, surfacing the keyword stats from IStatFactory as IStatBuilders, damage effectiveness)

- MainHand only skills
- dual wield requiring skills
- shield requiring skills
- weapon restrictions

(Vaal) Dual Strike and (Vaal) Cyclone have base_skill_number_of_additional_hits.
Double Strike, Cleave and Riposte have skill_double_hits_when_dual_wielding.

Requirements come from the gem, not the skill. Item-innate skills do not apply requirements.
Change all other modifiers in ActiveSkillParser to be global. Skill local isn't required for any of them.

to parse quality and level stats.

to select the file to be used for translations.

so that ActiveSkillParser can simply run them in a loop.

("increases and reductions to minion damage/attack speed" is parsed but won't yet actually do anything else than setting a flag)

Was not run by dotCover for some reason.

(not tested except for the behavior itself)

to only take the highest PathTotal (one path per item and gem)  as UncappedSubtotal

(required for the conversion behaviors)

(currently hardcoded for Added Cold Damage)

Remove parsedStats as part of its parse result, it had no effect.

and use it to refactor SupportSkillParser to work like ActiveSkillParser's (except that ManaMultiplier usage is still in SupportSkillParser  itself).

- Remove the obsolete constructor from SkillDefinition
- Pass SkillDefinitions to SkillBuilderCollection and do Keyword filtering there
- Change ISkillBuilders.FromName to .FromId to remove ambiguity
- Change SkillMatchers to use all SkillDefinitions (these will need to be filtered in some way once the real model is used because some definitions have the same display name)

Remove Console.SkillDefinitions.
Async loading of it requires most properties of CompositionRoot to be Tasks (now in AsyncCompositionRoot).

Add Concat for cases where results can not be merged logically (CombineWith increased the result count exponentially. Merging with some kind of zipping would be possible in some cases, but that can't really be determined automatically. The simplest solution is to simply concat the results.)

by sharing the CompositionRoot instance

(can currently activate the same skill multiple times)

via new {skillId}.ActiveSkillItemSlot and -SocketIndex stats. A behavior for these that arbitrarily selects the active instance will follow.

that takes the BaseSet modifier with maximum value. ItemSlot socketIndex combinations are unique so this can be used to identify the active skill.

(if the supported skill is the active instance)

Requires a skill (item slot and socket) specific cost stat so TotalOverride can be used on it.

Fix ManaCostOverride affecting the support instead of the active skill

…ource

…ageSource

…amageSource

Remove HitDamageSource and HasSkillDamageOverTime from SkillPreParser and SkillPreParseResult.

These expand the skill definitions from the game model to allow for skill parts, identifying buff modifiers, adding/removing modifiers and adding/removing keywords.

The extensions are far from complete and not used in parsing.
Some things can't be supported this way, mainly adding custom modifiers. Those will probably be added to the given data in Computation.Data later on.

Add AnyDamageType extension method to IDamageTypeBuilders

(no support, buff, minion and item-inherent skills)

so it can be used by Matchers in Computation.Data

- Add parsing of the remaining mods to Data
- Add AdditionslSkillStats IGivenStats to add mechanical modifiers that can't be added to SkillDefinitionExtensions

(except for what's required from Active-/SupportSkillParser)

in TranslatingSkillParser. Also refactor it so PartialSkillParseResult.ParsedStats are never parsed, independent of the type of stats.

The stats in there only have translations for conditional variants. The unconditional stats occur from renaming in SkillDefinitionExtensions.
Change IStatTranslator to return the unknown UntranslatedStats, allowing stat translators to be chained easily.

and use it to parse chance to be stunned

to allow activating Arcane Surge and Innervation buffs when the support is socketed

More lines of code but easier to read and more data-like

(these are active without the skill being the main skill and affect the skill's buff, e.g. the increased aura effect from generosity)

(instead of skillName) and add a LocalSource property to ModifierSource.Global (was previously private).

This allows referencing the parsed skill from builders while parsing.

These have to be added to most builders' Build methods to be passed through. Therefore there are a ton of changed files.
Having them in ICoreBuilder.Build() allows adding a skill builder that builds to the modifier source skill.