Jewel Support Part 2: Equipment UI #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a socket property to Item to store the socketing information. Socket null is for everything not jewel.
(it did work already, but error messages are annoying)
Remove ItemAttributes.Attributes Add ItemChanged event to ItemAttributes and remove Notifier implementation
and don't display them when not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds jewel support to the Equipment tab. It includes the connection to Computation, where support was added with #531.
Abyss jewel sockets are enabled and visualized based on the slotted item's socket count.
The only connection to the skill tree is enabling/disabling jewel sockets in the Equipment UI based on the skill tree node's skilled state. That makes it kinda hard to determine which socket in the Equipment tab corresponds to which tree node. Some solution to that will come at a later point.
I've removed the tabs from the "Attributes" that included items because they are kinda redundant already and it made this PR easier to implement.
Closes #163