fix(tests): making the tests not change the time #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
force-pushed
the
fix/test-timers
branch
from
102f844
to
6e43f7f
Compare
bassrock
requested review from
kschelonka
and removed request for
marcin-kozinski
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bassrock
force-pushed
the
fix/test-timers
branch
from
6e43f7f
to
b9061b9
Compare
Plan Result (user-list-search-cdk) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When I moved the list api and other services, I moved them and replaced sinon with pure jest. There was some weird behavior with the new timers behavior in Jest that I could not fully sort out at the time that caused us to have to set
advanceTimerstotrue. This had the side effect of causing our tests that check dates to be a bit flakey because the time could increment in the amount of time it took to run the test instead of beingUpon looking into the behavior
advanceTimerswas needed because the new timer behavior fakes async tick functions that we don't want it to. See nock/nock#2200 (comment)By telling jest to not fake the async node functions, the clock stays frozen and the rest of the code can execute.