Upgrade CSP to C++20; build websocket against C++17; rename .hi files #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek,
timkpaine and
czgdp1807
as code owners
robambalu
reviewed
May 9, 2024
Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
AdamGlustein
force-pushed
the
upgrade-csp-to-cpp20
branch
from
e12c3bf
to
dcc525c
Compare
robambalu
approved these changes
May 9, 2024
Carreau
pushed a commit
to Carreau/csp
that referenced
this pull request
May 13, 2024
…Point72#224) Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
Carreau
added a commit
to Carreau/csp
that referenced
this pull request
May 13, 2024
This is an empty commit, it is kept for information purposes. This is a rewritten branch, that squash the content of PR Point72#142 into a single commit (keeping a merge commit). Due to the merkel tree nature of git, all the subsequent commits have been rewritten, have a different hash and so it will need a force push. For completeness here is the current list of commits on main that have been rewritten and their new counterpart: old new e1e1f82 7b3c3a7 : Python 3.12 build support (Point72#221) a32cef3 2abdf59 : Update vcpkg baseline (Point72#209) 8bae523 c51a86b : Merge pull request Point72#189 from Point72/pavithraes/fix-links 0964fad 7a25f45 : Merge pull request Point72#219 from Point72/wrr/fix_ws_json_mapper 755debf cc60b87 : Merge pull request Point72#191 from Point72/ac/fix_to_json_parsing_floats 5c7e55f ba90a02 : Merge pull request Point72#200 from Point72/tkp/docs 2568689 abcd307 : Move websocket example after merge f9b7e62 da4d5e3 : fix format changes that will now result in lint failures 687dc2e d6479c5 : Upgrade CSP to C++20; build websocket against C++17; rename .hi files (Point72#224) 9b442d5 8adb1a7 : Upgrade baseline in vcpkg.json 92b7e34 d9ac41d : Pin linters to narrow range to avoid noise ee1aaf2 f11b8fc : PushPullInputAdapter - fix to previous patch that fixed out of order time handling. Need to account for the null event which signifies end of replay fef2fac 68927fe : Update to arrow / pyarrow 16 (Point72#210) 4717f54 086c9d5 : Add placeholder block to build action for service tests (in another PR) 306a530 ef1a239 : Merge pull request Point72#195 from Point72/bugfix/push_pull_ooo_patch fc239d5 4ea4799 : Maintain the type of a list-derived object when converting a struct in to_dict (Point72#199) adc79fd f6b0963 : Parse None natively in to_json method 3871e4a df3bb2d : Merge pull request Point72#196 from Point72/revert-194-ac/upgrade_vcpkg_43d81795a 6c57fb3 8a0d881 : Remove all caching code from CSP (Point72#213) 9729984 e70e4d7 : Merge pull request Point72#174 from Point72/tkp/slacktut 964c77e 12cceeb : Merge pull request Point72#223 from Point72/tkp/lint 801aa60 86c4e6d : Revert "Upgrade baseline in vcpkg.json" 7b07bea 64559cb : Include AS statement in SQL build query regardless of sqlalchemy version (Point72#205) 4621584 5103026 : Re-apply lost updates in dev guides (Point72#202) 5cde2c7 68dda2f : Merge pull request Point72#192 from Point72/ac/parse_none_to_json 6b4f38b efe0fd6 : Add format check to lint step 4a7dc36 eaec4a0 : Update baseline to stable version c5acdc8 3ca95b3 : Merge pull request Point72#194 from Point72/ac/upgrade_vcpkg_43d81795a 00c2a06 471e142 : Run autofixers with pinned up packages b748dc7 7441fb5 : Add build-debug option to Makefile so we dont forget the proper incantations (Point72#222) 24c5818 89eda4c : fix @217 | add tests 96a47b9 118a2fb : Fix to_json serialization for floats 895563c 78e7aca : Merge pull request Point72#211 from Point72/tkp/checklint 063b137 e2a4f2b : Fix interrupt handling issues in csp: ensure first node is stopped and reset signaled flag across runs (Point72#206) 7197c77 da9a84f : minor bugfix to unroll cppimpl. Missing cast from vector value to ElemT, which for bool would be a vector value of unsigned char. This was triggering a CSP_ASSERT in debug builds With the exception of the squashed one : faee778 : Merge pull request Point72#142 from Point72/pavithraes/docs-restructure that is a squash of all of Point72#142 All commits before that until 5d7eeb are unchanged You can use the following command using this commit message to check each of those commits vs their counterpart: ``` $ git show HEAD |tail -n +16 |head -n 35 | cut -f 1 -d: | xargs -L1 git diff --stat ```
robambalu
pushed a commit
that referenced
this pull request
May 17, 2024
…#224) Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
robambalu
pushed a commit
that referenced
this pull request
May 17, 2024
…#224) Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
timkpaine
added
lang: c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.