Implement FastList type for Struct list fields #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogarokpeter
requested review from
robambalu,
AdamGlustein,
svatasoiu,
alexddobkin,
ptomecek,
timkpaine and
czgdp1807
as code owners
AdamGlustein
requested changes
May 24, 2024
ogarokpeter
force-pushed
the
feature/fastlist
branch
2 times, most recently
from
bdc5688
to
efc3e05
Compare
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
ogarokpeter
force-pushed
the
feature/fastlist
branch
from
efc3e05
to
c7c23ec
Compare
robambalu
approved these changes
May 24, 2024
AdamGlustein
approved these changes
May 24, 2024
timkpaine
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSP users can opt in to use FastList by annotating their Struct list fields as FastList[T}. FastList implements all Python list methods, almost all natively in C++, thus allowing speed up list operations by minimizing conversion overhead.