Bug #965 #30
Merged
Bug #965 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2013 07:07
Use patch provided Marvin Gordon to speed up clusters extraction in the loop. Replce the copy part by a proper constructor improved further the performances.
Replace std::cout with proper pcl::console::print_* Add watch to get extraction time Provide an optional switch "-dump" to write out extracted clusters to "clusters.dat"
jspricke
added a commit
that referenced
this pull request
Mar 28, 2013
|
Hi Nizar, thanks for the patch! Just as a comment, you can rewrite your commits in git, so that you don't have to push the coding style changes as an extra commit ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this issue and made the example application nicer with use of console::print_*