Clang format gpu/segmentation #4819
Conversation
gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_clusters.h
Outdated
Show resolved
Hide resolved
gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_labeled_clusters.h
Outdated
Show resolved
Hide resolved
gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_labeled_clusters.h
Outdated
Show resolved
Hide resolved
| /* | ||
| if(tree_->cloud_.size() != host_cloud.size ()) | ||
| { | ||
| PCL_ERROR("[pcl::gpu::EuclideanClusterExtraction] size of host cloud and device |
There was a problem hiding this comment.
Him, this is a good question! This check seems to be active in the corresponding cpu method, but I am not sure this check is needed. I think constructing the tree with a superset of the pointcloud used for clustering should work. Nevertheless, I would prefer to activate it again in the GPU module for the sake of symmetry. What do you think?
There was a problem hiding this comment.
@larshg Thoughts?
(separate PR)
| if(tree_->cloud_.size() != host_cloud.size ()) | ||
| { | ||
| PCL_ERROR("[pcl::gpu::EuclideanClusterExtraction] size of host cloud and device | ||
| cloud don't match!\n"); return; |
There was a problem hiding this comment.
see comment above above
|
Add it to the script Line 11 in d242fcb |
|
Sorry for the long radio silence - I've been moving place. I added the the folder to the format.sh script. Thanks for pointing that out, @larshg ! |
|
@mvieth Merge? 🚀 |
|
No objections from my side |
* clang-format and some manual changes * second round of clang-format * corrected clang-format idiosyncrasies * corrected spelling mistake * added gpu/segmentation to format file
After #4677 got merged, I wanted to do some summer cleaning (or winter cleaning if you read this from the southern hemisphere) in the segmentation codebase. I applied clang-format and did some manual modifications. Everything looks nice and shiny :-)