correspondence estimation for different point types #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source and target point types
…source and target point types
…ation-for-neq-point-types
…ation-for-neq-point-types
…ation-for-neq-point-types
…source and target point types
…source and target point types
…source and target point types
|
This has a large overlap with PR #4901 . I don't want to review the same changes twice. Could you either modify the PRs so that each change is contained in only one PR, or mark one PR as a draft, then we review and merge the other PR first and deal with any additional changes after that? |
|
i marked this one as a draft, first please review the other one |
|
@al-tu would you rebase this one? |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extending #4901 with impl and tests for different point types