Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated function boost::filesystem::extension #5904

Merged
merged 3 commits into from
Dec 20, 2023
Merged

replace deprecated function boost::filesystem::extension #5904

merged 3 commits into from
Dec 20, 2023

Conversation

cybaol
Copy link
Contributor

@cybaol cybaol commented Dec 18, 2023

Task 2 of #5881

larshg
larshg previously approved these changes Dec 18, 2023
View reviewed changes
@mvieth
Copy link
Member

mvieth commented Dec 19, 2023

I found three instances of fs::extension in gpu/kinfu_large_scale/tools/kinfuLS_app.cpp, gpu/people/tools/people_app.cpp, and gpu/kinfu/tools/kinfu_app.cpp. Could you replace those as well, please?

@cybaol
Copy link
Contributor Author

cybaol commented Dec 19, 2023 •
edited

I found three instances of fs::extension in gpu/kinfu_large_scale/tools/kinfuLS_app.cpp, gpu/people/tools/people_app.cpp, and gpu/kinfu/tools/kinfu_app.cpp. Could you replace those as well, please?

The clang-tidy errors seem not related?

@cybaol
Copy link
Contributor Author

cybaol commented Dec 20, 2023

b52465d

mvieth
mvieth approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the clang-tidy errors are not your fault.
Thanks for replacing boost::filesystem::extension!

@mvieth mvieth added the changelog: fix Meta-information for changelog generation label Dec 20, 2023
@mvieth mvieth merged commit eccdbe8 into PointCloudLibrary:master Dec 20, 2023
15 of 16 checks passed
@cybaol cybaol deleted the replace_deprecated_boost_filesystem_extension branch December 20, 2023 11:22
@mvieth mvieth changed the title replace deprecated boost filesystem extension replace deprecated function boost::filesystem::extension Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvieth mvieth mvieth approved these changes

@larshg larshg larshg left review comments

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cybaol @mvieth @larshg