Add bugprone-macro-parentheses clang-tidy check

[gnawme]

Adds the bugprone-macro-parentheses check to clang-tidy:

Finds macros that can have unexpected behavior due to missing parentheses.

There are macros that use std::stringstream to simulate variadic functions; these should probably be converted to use actual parameter packs.

[mvieth]

Seems like there are also some parentheses needed in pcl_config.h (PCL_VERSION_CALC)

[gnawme]

@mvieth what is with pcl_config.h? It's not showing up as tracked in my repo but I can see my fixes:

#define PCL_VERSION_CALC(MAJ, MIN, PATCH) ((MAJ)*100000+(MIN)*100+(PATCH))

However, CI is showing this:

/__w/pcl/pcl/include/pcl/pcl_config.h:17:44: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
#define PCL_VERSION_CALC(MAJ, MIN, PATCH) (MAJ*100000+MIN*100+PATCH)
                                           ^
                                           (  )
/__w/pcl/pcl/include/pcl/pcl_config.h:17:55: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
#define PCL_VERSION_CALC(MAJ, MIN, PATCH) (MAJ*100000+MIN*100+PATCH)
                                                      ^
                                                      (  )
/__w/pcl/pcl/include/pcl/pcl_config.h:17:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
#define PCL_VERSION_CALC(MAJ, MIN, PATCH) (MAJ*100000+MIN*100+PATCH)
                                                              ^
                                                              (    )

[larshg]

The pcl_config.h is generated from https://github.com/PointCloudLibrary/pcl/blob/master/pcl_config.h.in
And you should remove the one from the build directory again 😀

[mvieth]

Thanks!