Remove Deprecated Code for 1.15.0 release #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good - however you need to remove them for the CMakelists.txt as well, ad it cant find them now they where removed. pcl/apps/in_hand_scanner/CMakeLists.txt Line 21 in 5373884 |
Shayril
force-pushed
the
RemoveDeprecatedCode
branch
2 times, most recently
from
a838440
to
4ad13ce
Compare
|
Some of the files you deleted, shouldn't be deleted. Ie. visualization/include/pcl/visualization/pcl_visualizer.h. |
Shayril
force-pushed
the
RemoveDeprecatedCode
branch
2 times, most recently
from
8fb6650
to
16a71e1
Compare
Signed-off-by: Shayril <shayrilu.work@gmail.com>
Shayril
force-pushed
the
RemoveDeprecatedCode
branch
from
16a71e1
to
3ae4df5
Compare
larshg
approved these changes
May 16, 2024
|
Thank you @Shayril 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6039