Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to allow using MSVC2013 builds of PXCAPI #922

Closed
wants to merge 5 commits into from

Conversation

dtmoodie
Copy link

No description provided.

@taketwo
Copy link
Member

taketwo commented Sep 21, 2014

Hi, could you please remove the merge commit from this pull request? Thank you.

@taketwo
Copy link
Member

taketwo commented Sep 21, 2014

Also there seems to be an error in FindPXCAPI.cmake (see output from Travis):

CMake Error at cmake/Modules/FindPXCAPI.cmake:37 (endif):
  endif An ENDIF command was found outside of a proper IF ENDIF structure.
  Or its arguments did not match the opening IF command.

@dtmoodie
Copy link
Author

I'm sorry I'm still trying to figure out the github interface. I've been trying to remove f73a57c but can't find the functionality to do that.
Also I've noticed that even though there is a separate debug and release flag, both libraries are being added in both modes. Will sort out and update asap.

@taketwo
Copy link
Member

taketwo commented Sep 22, 2014

I've been trying to remove f73a57c but can't find the functionality to do that.

What you need is git rebase -i command.

@taketwo
Copy link
Member

taketwo commented Oct 23, 2015

PXCGrabber has been deprecated and removed (#1395). Please use the new DepthSenseGrabber.

@taketwo taketwo closed this Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants