Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Tests for filtering sometimes fail #21

Closed
tpoisot opened this issue Mar 11, 2019 · 2 comments · Fixed by #36
Closed

Tests for filtering sometimes fail #21

tpoisot opened this issue Mar 11, 2019 · 2 comments · Fixed by #36
Labels

Comments

@tpoisot
Copy link
Member

tpoisot commented Mar 11, 2019

My best guess as to why is: sometimes the most recent observations have no issues, and so the tests (which is testing the fact that the length before/after changes) are failing. This can be solved by putting a function which will remove some records e.g. at random, like f(g::GBIFRecord) = rand() < 0.5.

@tpoisot tpoisot added the bug label Mar 11, 2019
@mkborregaard
Copy link
Contributor

will that not lead the tests to always pass?

@tpoisot
Copy link
Member Author

tpoisot commented Mar 12, 2019

The specific test is that after a filtering that removes some species, the length of the records object should be lower than before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants