GBIF throws 404 (not 410) for deleted resources #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tpoisot
commented
Feb 18, 2023
•
tpoisot
commented
- Update the tests with a failing occurrence
- Add a way to handle 404 when querying deleted occurrences
|
Documentation for this PR at https://poisotlab.github.io/SpeciesDistributionToolkit.jl/previews/PR156/ |
tpoisot
added
bug
Codecov ReportBase: 47.49% // Head: 40.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 47.49% 40.53% -6.96%
==========================================
Files 36 28 -8
Lines 1196 1014 -182
==========================================
- Hits 568 411 -157
+ Misses 628 603 -25
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tpoisot
added a commit
that referenced
this pull request
Feb 18, 2023
* 🤢 GBIF throws 404 (not 410) for deleted resources * 🐛 throws an error when the occurrence is not available * ✅ 404 error on single occurrence is handled
tpoisot
added a commit
that referenced
this pull request
Feb 21, 2023
#153) * 🩹 SimpleSDMLayers version bump * ✅ test for clipping with natural coordinates (#152) * 🐛 no use of stride in clip / expand keyword * 🐛 Update the stitching code to get the right bounding box (#155) * 🐛 Stitch returns the wrong bounding box in the end Fixes #154 * 🟩 test the stitch patch * 🟩 some more tests for the right coordinate * 🟩 removed a test where the layer type changes * ➖ drop dependencies for SimpleSDMLayers test * 🟩 tests with the expand keyword * GBIF throws 404 (not 410) for deleted resources (#156) * 🤢 GBIF throws 404 (not 410) for deleted resources * 🐛 throws an error when the occurrence is not available * ✅ 404 error on single occurrence is handled * 🟥 remove the subsetting test (handled by clip) * 🐛 fix clipping with natural coordinates * 🐛 fix approximation in displayed coordinate * 🐛 tests when clipping exactly on the limit * ✅ add test comparing clip with gdalwarp * 🐛 missing end for test module --------- Co-authored-by: Gabriel Dansereau <gabriel.dansereau@umontreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.