Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression/format kwargs for geotiffs #161

Merged
merged 10 commits into from
Mar 8, 2023
Merged

compression/format kwargs for geotiffs #161

merged 10 commits into from
Mar 8, 2023

Conversation

gottacatchenall
Copy link
Member

@gottacatchenall gottacatchenall commented Feb 24, 2023

Closes #160 - support to specify the geotiff driver

@github-actions
Copy link
Contributor

@tpoisot
Copy link
Member

tpoisot commented Feb 24, 2023

Is there a list of supported drivers that we could check against before trying to use them?

@gottacatchenall
Copy link
Member Author

GDAL provides a list of supported drivers here, although it's possible ArchGDAL or typical GDAL distributions don't support them all

@tpoisot
Copy link
Member

tpoisot commented Feb 25, 2023

I'm looking at that table like

Screen_Shot_2020-07-24_at_11 33 38_AM

@tpoisot
Copy link
Member

tpoisot commented Feb 25, 2023

but maybe we can stick to the "built-in by default"?

@tpoisot
Copy link
Member

tpoisot commented Feb 25, 2023

GDAL has a list of drivers here: https://github.com/JuliaGeo/GDAL.jl/blob/040bda4ac1b57fbd18239036f08c8b8fcf06849e/test/drivers.jl

So we can stick them in a const, and check that the driver matches. The list isn't exported by GDAL, but we can copy-paste it.

@gottacatchenall
Copy link
Member Author

nice! spatial projection change could also be as easy as an arbitrary kwarg if GDAL/ArchGDAL has a list of valid EPSGs, i can check if they do

@tpoisot
Copy link
Member

tpoisot commented Feb 25, 2023

So, ArchGDAL.listdrivers() should get us the valid driver names. We can work on the valid EPSGs later.

tpoisot and others added 6 commits February 25, 2023 15:32
* 🧑‍🏫 Move the packages documentation to the manual folder

* 🧑‍🏫 index doc page

* 🧑‍🏫 top level package

* 🧑‍🏫 pseudoabsence mask documentation

* 🧹 EOF line

* 🧑‍🏫 layers types

* 🧑‍🏫 update layers doc
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 5.88% and project coverage change: +5.95 🎉

Comparison is base (4c63b82) 48.59% compared to head (3623297) 54.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   48.59%   54.55%   +5.95%     
==========================================
  Files          36       47      +11     
  Lines        1214     1514     +300     
==========================================
+ Hits          590      826     +236     
- Misses        624      688      +64     
Flag Coverage Δ
unittests 54.55% <5.88%> (+5.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Fauxcurrences/src/bootstrap.jl 0.00% <ø> (ø)
Fauxcurrences/src/utilities.jl 0.00% <ø> (ø)
GBIF/src/occurrence.jl 93.22% <ø> (ø)
GBIF/src/paging.jl 92.00% <0.00%> (ø)
GBIF/src/types/GBIFRecords.jl 92.00% <ø> (ø)
src/integrations/gbif_layers.jl 0.00% <0.00%> (ø)
src/pseudoabsences.jl 0.00% <ø> (ø)
src/io/geotiff.jl 76.36% <66.66%> (-0.28%) ⬇️
...MDatasets/src/providers/CHELSA/chelsa_future_v2.jl 100.00% <0.00%> (ø)
...impleSDMDatasets/src/providers/CHELSA/chelsa_v2.jl 90.90% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot merged commit 4424ec0 into main Mar 8, 2023
@tpoisot tpoisot deleted the mdc/archgdal_args branch March 8, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geotiff driver kwarg
4 participants