Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the naming issue when imported from a submodule #167

Merged
merged 4 commits into from
Apr 16, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Apr 16, 2023

Closes #164

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28 🎉

Comparison is base (ff4a23e) 54.55% compared to head (dc7faae) 54.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   54.55%   54.84%   +0.28%     
==========================================
  Files          47       47              
  Lines        1514     1528      +14     
==========================================
+ Hits          826      838      +12     
- Misses        688      690       +2     
Flag Coverage Δ
unittests 54.84% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SimpleSDMDatasets/src/downloader.jl 83.33% <100.00%> (+6.66%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot
Copy link
Member Author

tpoisot commented Apr 16, 2023

Plus or minus the fact that WorldClim is really wonky, this seems to be working.

@tpoisot tpoisot marked this pull request as ready for review April 16, 2023 16:32
@tpoisot tpoisot merged commit 39a871e into main Apr 16, 2023
@tpoisot tpoisot deleted the bug/namespace-layers branch April 16, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downloaders break when imported as part of another module
2 participants