Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate of #959 #961

Merged
merged 17 commits into from
Dec 1, 2023
Merged

Duplicate of #959 #961

merged 17 commits into from
Dec 1, 2023

Conversation

Naramsim
Copy link
Member

No description provided.

simonorono and others added 15 commits November 26, 2023 11:57
…sonb`

This is so Hasura automatically transforms the field into an array
instead of a JSON encoded in a string.

Migration was generated by the `makemigrations` command.
Since the column is now jsonb, we need to stop encoding it or it gets
inserted as a string rather than a JSON object.
Some third-party packages had to be updated and some new settings were
added due to `manage.py` not running.
This was preventing the tests from running.
The models affected were PokemonFormSprites and ItemSprites. This was
done to ensure they are properly returned when querying those tables
with Hasura.
Moved the declaration of sprite_data variables closer to their actual
usage.
@Naramsim Naramsim marked this pull request as ready for review November 30, 2023 03:13
@Naramsim Naramsim merged commit ae88bdd into master Dec 1, 2023
5 checks passed
@Naramsim
Copy link
Member Author

Naramsim commented Dec 1, 2023

@simonorono @C-Garza I merged this PR since I added some improvements to the CICD. This PR fixed the image error you had in your PR @simonorono : https://github.com/PokeAPI/api-data/pull/199/files

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants