-
-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate of #959 #961
Merged
Duplicate of #959 #961
Commits on Nov 26, 2023
-
Make the type of the
sprites
column in pokemon_v2_pokemonsprites `j……sonb` This is so Hasura automatically transforms the field into an array instead of a JSON encoded in a string. Migration was generated by the `makemigrations` command.
Configuration menu - View commit details
-
Copy full SHA for 218864d - Browse repository at this point
Copy the full SHA 218864dView commit details -
Stop encoding sprites when inserting them on the database
Since the column is now jsonb, we need to stop encoding it or it gets inserted as a string rather than a JSON object.
Configuration menu - View commit details
-
Copy full SHA for fa14336 - Browse repository at this point
Copy the full SHA fa14336View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ff2c0c - Browse repository at this point
Copy the full SHA 6ff2c0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49d970f - Browse repository at this point
Copy the full SHA 49d970fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30e8a01 - Browse repository at this point
Copy the full SHA 30e8a01View commit details -
Some third-party packages had to be updated and some new settings were added due to `manage.py` not running.
Configuration menu - View commit details
-
Copy full SHA for 8f716cd - Browse repository at this point
Copy the full SHA 8f716cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1e2d9c - Browse repository at this point
Copy the full SHA d1e2d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for db33cfc - Browse repository at this point
Copy the full SHA db33cfcView commit details -
This was preventing the tests from running.
Configuration menu - View commit details
-
Copy full SHA for 45efd07 - Browse repository at this point
Copy the full SHA 45efd07View commit details -
Configuration menu - View commit details
-
Copy full SHA for d57fd5a - Browse repository at this point
Copy the full SHA d57fd5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dcaf0d - Browse repository at this point
Copy the full SHA 0dcaf0dView commit details -
Use JSONField instead of CharField for sprites
The models affected were PokemonFormSprites and ItemSprites. This was done to ensure they are properly returned when querying those tables with Hasura.
Configuration menu - View commit details
-
Copy full SHA for 76f7a34 - Browse repository at this point
Copy the full SHA 76f7a34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61c2185 - Browse repository at this point
Copy the full SHA 61c2185View commit details -
Moved the declaration of sprite_data variables closer to their actual usage.
Configuration menu - View commit details
-
Copy full SHA for b3d6608 - Browse repository at this point
Copy the full SHA b3d6608View commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b348e60 - Browse repository at this point
Copy the full SHA b348e60View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7f2be7 - Browse repository at this point
Copy the full SHA f7f2be7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f4712 - Browse repository at this point
Copy the full SHA 35f4712View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.