Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DLC2 learnsets #999

Merged
merged 6 commits into from
Jan 13, 2024
Merged

Add DLC2 learnsets #999

merged 6 commits into from
Jan 13, 2024

Conversation

penelopeysm
Copy link
Contributor

@penelopeysm penelopeysm commented Jan 11, 2024

Hello! This PR adds in learnsets for Indigo Disk, including old mons which can now learn new TMs. @giginet, I'm very sorry it's taken me longer than I had anticipated to get round to this! I had a lot of real life stuff to take care of.

As before, I have not exhaustively verified the data, I've just checked a few entries by hand. Let me know if anything needs updating :)

Closes #987

@Naramsim
Copy link
Member

This is a big PR, I'd wait some days for a review. Otherwise I'll merge

@giginet
Copy link
Contributor

giginet commented Jan 11, 2024

Thank you! I’ll check this in this weekend.

@giginet
Copy link
Contributor

giginet commented Jan 13, 2024

@penelopeysm Thank you again for this great contribution 😄

I checked your data in my tool. I found some issues.

  • 1020 Gouging Fire
  • 1021 Raging Bolt
  • 1022 Iron Boulder
  • 1023 Iron Crown

They seem to be reflecting only moves learned by new TMs.

Screenshot 2024-01-13 at 14 35 02

Could you check them again?

Additionally, I checked some situations:

  • All new Pokémon in this DLC
  • Some Pokémon returned in this DLC
  • Some Pokémon introduced in the original game then added moves since this DLC
  • Some Pokémon introduced in DLC1 and added moves since this DLC

As I checked, no more issues were found. Thank you.

@penelopeysm
Copy link
Contributor Author

Ah, I missed those. That should be fixed now! Thank you for checking!

Copy link
Contributor

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the data, it seems to be correct 💯

Thank you very much again!

@Naramsim
Copy link
Member

Thanks so much @penelopeysm !!! And @giginet thanks for the review!

@Naramsim Naramsim merged commit e969d62 into PokeAPI:master Jan 13, 2024
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jan 13, 2024
@penelopeysm penelopeysm deleted the 987-dlc2-learnset branch January 13, 2024 17:24
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jan 13, 2024
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jan 15, 2024
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jan 22, 2024
Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jan 22, 2024
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jan 29, 2024
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add learnset introduced since Indigo Disk
4 participants