Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining DLC2 movesets (legendaries, Exeggcute, Duraludon) #1007

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

penelopeysm
Copy link
Contributor

Added movesets for a handful of legendary Pokemon, plus Exeggcute and Duraludon which I somehow missed out in #999.

Closes #1006

(This time I iterated through the entire database to make sure that all Pokemon with nonempty SV moveset had at least one level-up move, which was how I caught the two extra missing mons. In theory it's possible that I still missed something, but at least it's much less likely.)

Copy link
Contributor

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a quick support! 😮

I confirmed all Legendary Pokémon I listed, Exeggcute, and Duraludon.

It's almost good. But I noticed some Legendary Pokémon have egg moves.
Screenshot 2024-01-15 at 21 22 04

As I investigated the context, PokeAPI doesn't distinguish between egg moves and moves learned only by Move Remember.
https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/pokemon_move_methods.csv

So, these data would be correct. Thank you. 🌸 💯

@Naramsim Naramsim merged commit e4b5544 into PokeAPI:master Jan 15, 2024
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing level moves on some Legendary Pokémon introduced since Indigo Disk
4 participants