Cache testing #29
Merged
Cache testing #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kronopt
commented
Feb 3, 2019
•
Kronopt
commented
- Tests for cache feature
- Fixed cache dir bug when using default cache_location parameter
- Added cache_type property to V2Client
- Fixed other small typos
- refactored main variables and test names - separated uid str tests from uid int tests
- __repr__ testing
- Fixed cache dir bug when using default cache_location parameter - Added cache_type property to V2Client - Changed setUp(self) to setUpClass(cls). setUp was called every time before each test... - Created TestV2ClientCacheInDisk with tearDownClass(cls) to clear cache directory - Tests (for both in-disk and in-memory): -- 'cache_info' - test cache_info (0 hit, 0 miss, 0 cache) -- 'cache_clear' - test cache_clear (0 hit, 0 miss, 0 cache) -- 'cache_location' - test cache location -- '011' - 0 hit, 1 miss, 1 cached -- '111' - 1 hit, 1 miss, 1 cached -- '022' - 0 hit, 2 miss, 2 cached
- Test upper case strings for uid
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 85.63% 93.59% +7.95%
==========================================
Files 3 3
Lines 1058 1061 +3
==========================================
+ Hits 906 993 +87
+ Misses 152 68 -84
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.