Add enchantments topping #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not ready for merge, just realized that enchantment ids are not sequential in old versions. Going to fix that first |
|
This would need to be rebased onto the new branch even if it worked, so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address PrismarineJS/minecraft-data#325
It uses the exact same approach as the particletypes topping. There's more useful data to be extracted from enchantments (Slot restrictions, rarity, protection status), but this is enough to address the minecraft-data issue. The string ambiguity is irrelevant for the time being since both detected classes load all of the string constants.
Tested on every version >= 1.8.8